Skip to content

Add myself as ext/reflection maintainer [skip ci] #18138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Add myself as ext/reflection maintainer [skip ci] #18138

merged 1 commit into from
Mar 25, 2025

Conversation

@DanielEScherzer
Copy link
Member

No description provided.

@DanielEScherzer DanielEScherzer changed the base branch from master to PHP-8.3 March 24, 2025 19:45
@DanielEScherzer
Copy link
Member Author

DanielEScherzer commented Mar 24, 2025 •
edited
Loading

Figured out how to sign commits :)
I'll merge this myself once I have that part set up

devnexen
devnexen approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey ! welcome !

@DanielEScherzer
Copy link
Member Author

Okay, lets try this

@DanielEScherzer DanielEScherzer merged commit c45d608 into php:PHP-8.3 Mar 25, 2025
1 check passed
@DanielEScherzer
Copy link
Member Author

I think I did this right, but would someone mind confirming?

  • squashed in the online interface so that it gets marked as verified
  • merged to 8.4 in 87d7532
  • merged to master in 5c3cff2

@nielsdos
Copy link
Member

Seems legit

@DanielEScherzer DanielEScherzer deleted the reflection-codeowners branch March 25, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimWolla TimWolla TimWolla approved these changes

@devnexen devnexen devnexen approved these changes

@nielsdos nielsdos nielsdos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DanielEScherzer @nielsdos @TimWolla @devnexen